Skip to content

fix: Replace pytz with stdlib datetime.timezone and zoneinfo (#5863) #5917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sagemaker-bot wants to merge 1 commit into
base: master-v2
Choose a base branch
from
+4 −4
Open

fix: Replace pytz with stdlib datetime.timezone and zoneinfo (#5863) #5917

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tests/unit/sagemaker/workflow/test_triggers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
from datetime import datetime

import pytest
import pytz
from zoneinfo import ZoneInfo
from mock.mock import ANY
from sagemaker.workflow.parameters import ParameterInteger, ParameterFloat, ParameterBoolean

Expand Down Expand Up @@ -47,7 +47,7 @@
PIPELINE_ARN = "arn:pipeline/TestSchedulerPipeline"
PIPELINE_NAME = "TestSchedulerPipeline"

PACIFIC = pytz.timezone("US/Pacific")
PACIFIC = ZoneInfo("US/Pacific")


@pytest.fixture
Expand Down Expand Up @@ -105,8 +105,8 @@ def test_resolve_schedule_expressions_common_cases(inputs):
@pytest.mark.parametrize(
"input_dt, expected_dt",
[
(PACIFIC.localize(INPUT_AT_DATETIME_PST), EXPECTED_AT_EXPRESSION), # PST -7UTC)
(PACIFIC.localize(INPUT_AT_DATETIME_PDT), EXPECTED_AT_EXPRESSION_DST), # PDT -8UTC
(INPUT_AT_DATETIME_PST.replace(tzinfo=PACIFIC), EXPECTED_AT_EXPRESSION), # PST -7UTC)
(INPUT_AT_DATETIME_PDT.replace(tzinfo=PACIFIC), EXPECTED_AT_EXPRESSION_DST), # PDT -8UTC
(INPUT_AT_DATETIME_UTC, EXPECTED_AT_EXPRESSION), # UTC
],
)
Expand Down
Loading