-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: ModelBuilder.deploy() should expose DataCacheConfig and other CreateInferenceCom (5750) #5753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
05e59de
8bc8db3
ccc3425
869474a
f865a27
afcad51
7272444
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
aviruthen marked this conversation as resolved.
aviruthen marked this conversation as resolved.
aviruthen marked this conversation as resolved.
aviruthen marked this conversation as resolved.
aviruthen marked this conversation as resolved.
aviruthen marked this conversation as resolved.
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Two fixes needed:
# Replace:
kwargs["variant_name"] = variant_name or "AllTraffic"
# With:
if variant_name is not None:
kwargs["variant_name"] = variant_nameEach downstream path already has its own default — _deploy_core_endpoint defaults to "AllTraffic" via kwargs.get("variant_name", "AllTraffic"), and _deploy_model_customization defaults to endpoint_name via variant_name or endpoint_name or "AllTraffic".
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do not worry about CI failures! Removing the second integ test will fix one failure and the other failures are due to flakiness |
Uh oh!
There was an error while loading. Please reload this page.