Fix streaming timeout exception decoration#6975
Open
adwantg wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes #6866.
For streamed
S3AsyncClient#getObjectresponses, Netty can surfaceReadTimeoutExceptionthroughResponseHandler.PublisherAdapter.onError. That path was forwarding the raw Netty exception, unlike theexceptionCaughtpath, so the SDK retry path could miss the decoratedIOException.Modifications
NettyUtils.decorateExceptionbefore notifying the downstream subscriber and response handler.Testing
./mvnw -pl :netty-nio-client -am -Dtest=PublisherAdapterTest#streamingReadTimeout_shouldDecorateExceptionBeforeNotifyingHandlers -Dsurefire.failIfNoSpecifiedTests=false -Dspotbugs.skip=true -Dcheckstyle.skip=true test./mvnw -pl :netty-nio-client -am -Dtest=PublisherAdapterTest -Dsurefire.failIfNoSpecifiedTests=false -Dspotbugs.skip=true -Dcheckstyle.skip=true testI also attempted the broader netty module test command:
./mvnw -pl :netty-nio-client -am -Dsurefire.failIfNoSpecifiedTests=false -Dspotbugs.skip=true -Dcheckstyle.skip=true testThat broader local run reached the netty client suite but failed in
ServerConnectivityErrorMessageTest.closeTimeHasCorrectMessageon my JDK 21 environment because two local socket-close cases reportedConnection reset. The touchedPublisherAdapterTestclass passed.Screenshots (if appropriate)
N/A
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License