Fix HttpChecksumStage ordering and SIGNING_METHOD resolution for interceptors to pipeline migration#6965
Merged
S-Saranya1 merged 1 commit intoMay 15, 2026
Conversation
…line stage migration
RanVaknin
approved these changes
May 15, 2026
8af4695
into
feature/master/core-interceptors-migration
17 of 30 checks passed
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
After moving auth scheme resolution to a pipeline stage, SIGNING_METHOD is computed too early — before SELECTED_AUTH_SCHEME has the resolved values. This causes HttpChecksumStage to skip adding trailing checksums for requests that need them (e.g., S3 PutObject with MRAP + old signer), because ENABLE_CHUNKED_ENCODING is null at computation time.
Modifications
AmazonSyncHttpClient/AmazonAsyncHttpClient— Moved HttpChecksumStage to run after AuthSchemeResolutionStage and EndpointResolutionStage, so it reads SIGNING_METHOD after it's been recomputed.SdkInternalExecutionAttribute— Added SIGNING_METHOD_UPDATER callback attribute.AwsExecutionContextBuilder— Sets the SIGNING_METHOD_UPDATER callback that recomputes SIGNING_METHOD using resolveSigningMethodUsed() with the correct values.AuthSchemeResolutionStage— Invokes the SIGNING_METHOD_UPDATER callback after resolving the auth scheme, when ENABLE_CHUNKED_ENCODING is available on SELECTED_AUTH_SCHEME.Testing
Verified with existing ChecksumReuseTest - all 6 tests pass including the previously failing MRAP + old signer case.
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License