Skip to content

Make endpoint-rules blob internal and add C2J skip flag #3875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sbiscigl wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make endpoint-rules blob internal and add C2J skip flag #3875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a81490e
add option to disable blob generation. mark rules blob as local symbol.
sbiscigl Jul 22, 2026
b918c53
regenerate clients
sbiscigl Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
The diff you're trying to view is too large. We only load the first 3000 changed files.
6 changes: 6 additions & 0 deletions generated/src/aws-cpp-sdk-AWSMigrationHub/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ file(GLOB AWS_AWSMIGRATIONHUB_MODEL_HEADERS
"include/aws/AWSMigrationHub/model/*.h"
)

file(GLOB AWS_AWSMIGRATIONHUB_INTERNAL_HEADERS
"include/aws/AWSMigrationHub/internal/*.h"
)

file(GLOB AWS_AWSMIGRATIONHUB_SOURCE
"source/*.cpp"
)
Expand All @@ -18,6 +22,7 @@ file(GLOB AWS_AWSMIGRATIONHUB_MODEL_SOURCE

file(GLOB AWSMIGRATIONHUB_UNIFIED_HEADERS
${AWS_AWSMIGRATIONHUB_HEADERS}
${AWS_AWSMIGRATIONHUB_INTERNAL_HEADERS}
${AWS_AWSMIGRATIONHUB_MODEL_HEADERS}
)

Expand All @@ -39,6 +44,7 @@ if(WIN32)
#if we are compiling for visual studio, create a sane directory tree.
if(MSVC)
source_group("Header Files\\aws\\AWSMigrationHub" FILES ${AWS_AWSMIGRATIONHUB_HEADERS})
source_group("Header Files\\aws\\AWSMigrationHub\\internal" FILES ${AWS_AWSMIGRATIONHUB_INTERNAL_HEADERS})
source_group("Header Files\\aws\\AWSMigrationHub\\model" FILES ${AWS_AWSMIGRATIONHUB_MODEL_HEADERS})
source_group("Source Files" FILES ${AWS_AWSMIGRATIONHUB_SOURCE})
source_group("Source Files\\model" FILES ${AWS_AWSMIGRATIONHUB_MODEL_SOURCE})
Expand Down
5 changes: 1 addition & 4 deletions ...rc/aws-cpp-sdk-AWSMigrationHub/include/aws/AWSMigrationHub/MigrationHubEndpointProvider.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
*/

#pragma once
#include <aws/AWSMigrationHub/MigrationHubEndpointRules.h>
#include <aws/AWSMigrationHub/MigrationHub_EXPORTS.h>
#include <aws/core/client/GenericClientConfiguration.h>
#include <aws/core/endpoint/DefaultEndpointProvider.h>
Expand Down Expand Up @@ -42,9 +41,7 @@ class AWS_MIGRATIONHUB_API MigrationHubEndpointProvider : public MigrationHubDef
public:
using MigrationHubResolveEndpointOutcome = Aws::Endpoint::ResolveEndpointOutcome;

MigrationHubEndpointProvider()
: MigrationHubDefaultEpProviderBase(Aws::MigrationHub::MigrationHubEndpointRules::GetRulesBlob(),
Aws::MigrationHub::MigrationHubEndpointRules::RulesBlobSize) {}
MigrationHubEndpointProvider();

~MigrationHubEndpointProvider() {}
};
Expand Down
8 changes: 7 additions & 1 deletion generated/src/aws-cpp-sdk-AWSMigrationHub/include/aws/AWSMigrationHub/MigrationHub_EXPORTS.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,13 @@
#define AWS_MIGRATIONHUB_API
#define AWS_MIGRATIONHUB_EXTERN extern
#endif // USE_IMPORT_EXPORT
#else // defined (USE_WINDOWS_DLL_SEMANTICS) || defined (WIN32)
#define AWS_MIGRATIONHUB_LOCAL
#else // defined (USE_WINDOWS_DLL_SEMANTICS) || defined (WIN32)
#define AWS_MIGRATIONHUB_API
#define AWS_MIGRATIONHUB_EXTERN extern
#if __GNUC__ >= 4
#define AWS_MIGRATIONHUB_LOCAL __attribute__((visibility("hidden")))
#else
#define AWS_MIGRATIONHUB_LOCAL
#endif
#endif // defined (USE_WINDOWS_DLL_SEMANTICS) || defined (WIN32)
2 changes: 1 addition & 1 deletion ...SMigrationHub/MigrationHubEndpointRules.h → ...nHub/internal/MigrationHubEndpointRules.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

namespace Aws {
namespace MigrationHub {
class MigrationHubEndpointRules {
class AWS_MIGRATIONHUB_LOCAL MigrationHubEndpointRules {
public:
static const size_t RulesBlobStrLen;
static const size_t RulesBlobSize;
Expand Down
8 changes: 7 additions & 1 deletion generated/src/aws-cpp-sdk-AWSMigrationHub/source/MigrationHubEndpointProvider.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,15 @@
*/

#include <aws/AWSMigrationHub/MigrationHubEndpointProvider.h>
#include <aws/AWSMigrationHub/internal/MigrationHubEndpointRules.h>

namespace Aws {
namespace MigrationHub {
namespace Endpoint {} // namespace Endpoint
namespace Endpoint {
MigrationHubEndpointProvider::MigrationHubEndpointProvider()
: MigrationHubDefaultEpProviderBase(Aws::MigrationHub::MigrationHubEndpointRules::GetRulesBlob(),
Aws::MigrationHub::MigrationHubEndpointRules::RulesBlobSize) {}

} // namespace Endpoint
} // namespace MigrationHub
} // namespace Aws
2 changes: 1 addition & 1 deletion generated/src/aws-cpp-sdk-AWSMigrationHub/source/MigrationHubEndpointRules.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* SPDX-License-Identifier: Apache-2.0.
*/

#include <aws/AWSMigrationHub/MigrationHubEndpointRules.h>
#include <aws/AWSMigrationHub/internal/MigrationHubEndpointRules.h>
#include <aws/core/utils/memory/stl/AWSArray.h>

namespace Aws {
Expand Down
6 changes: 6 additions & 0 deletions generated/src/aws-cpp-sdk-accessanalyzer/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ file(GLOB AWS_ACCESSANALYZER_MODEL_HEADERS
"include/aws/accessanalyzer/model/*.h"
)

file(GLOB AWS_ACCESSANALYZER_INTERNAL_HEADERS
"include/aws/accessanalyzer/internal/*.h"
)

file(GLOB AWS_ACCESSANALYZER_SOURCE
"source/*.cpp"
)
Expand All @@ -18,6 +22,7 @@ file(GLOB AWS_ACCESSANALYZER_MODEL_SOURCE

file(GLOB ACCESSANALYZER_UNIFIED_HEADERS
${AWS_ACCESSANALYZER_HEADERS}
${AWS_ACCESSANALYZER_INTERNAL_HEADERS}
${AWS_ACCESSANALYZER_MODEL_HEADERS}
)

Expand All @@ -39,6 +44,7 @@ if(WIN32)
#if we are compiling for visual studio, create a sane directory tree.
if(MSVC)
source_group("Header Files\\aws\\accessanalyzer" FILES ${AWS_ACCESSANALYZER_HEADERS})
source_group("Header Files\\aws\\accessanalyzer\\internal" FILES ${AWS_ACCESSANALYZER_INTERNAL_HEADERS})
source_group("Header Files\\aws\\accessanalyzer\\model" FILES ${AWS_ACCESSANALYZER_MODEL_HEADERS})
source_group("Source Files" FILES ${AWS_ACCESSANALYZER_SOURCE})
source_group("Source Files\\model" FILES ${AWS_ACCESSANALYZER_MODEL_SOURCE})
Expand Down
5 changes: 1 addition & 4 deletions ...rc/aws-cpp-sdk-accessanalyzer/include/aws/accessanalyzer/AccessAnalyzerEndpointProvider.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
*/

#pragma once
#include <aws/accessanalyzer/AccessAnalyzerEndpointRules.h>
#include <aws/accessanalyzer/AccessAnalyzer_EXPORTS.h>
#include <aws/core/client/GenericClientConfiguration.h>
#include <aws/core/endpoint/DefaultEndpointProvider.h>
Expand Down Expand Up @@ -42,9 +41,7 @@ class AWS_ACCESSANALYZER_API AccessAnalyzerEndpointProvider : public AccessAnaly
public:
using AccessAnalyzerResolveEndpointOutcome = Aws::Endpoint::ResolveEndpointOutcome;

AccessAnalyzerEndpointProvider()
: AccessAnalyzerDefaultEpProviderBase(Aws::AccessAnalyzer::AccessAnalyzerEndpointRules::GetRulesBlob(),
Aws::AccessAnalyzer::AccessAnalyzerEndpointRules::RulesBlobSize) {}
AccessAnalyzerEndpointProvider();

~AccessAnalyzerEndpointProvider() {}
};
Expand Down
8 changes: 7 additions & 1 deletion generated/src/aws-cpp-sdk-accessanalyzer/include/aws/accessanalyzer/AccessAnalyzer_EXPORTS.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,13 @@
#define AWS_ACCESSANALYZER_API
#define AWS_ACCESSANALYZER_EXTERN extern
#endif // USE_IMPORT_EXPORT
#else // defined (USE_WINDOWS_DLL_SEMANTICS) || defined (WIN32)
#define AWS_ACCESSANALYZER_LOCAL
#else // defined (USE_WINDOWS_DLL_SEMANTICS) || defined (WIN32)
#define AWS_ACCESSANALYZER_API
#define AWS_ACCESSANALYZER_EXTERN extern
#if __GNUC__ >= 4
#define AWS_ACCESSANALYZER_LOCAL __attribute__((visibility("hidden")))
#else
#define AWS_ACCESSANALYZER_LOCAL
#endif
#endif // defined (USE_WINDOWS_DLL_SEMANTICS) || defined (WIN32)
2 changes: 1 addition & 1 deletion ...essanalyzer/AccessAnalyzerEndpointRules.h → ...er/internal/AccessAnalyzerEndpointRules.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

namespace Aws {
namespace AccessAnalyzer {
class AccessAnalyzerEndpointRules {
class AWS_ACCESSANALYZER_LOCAL AccessAnalyzerEndpointRules {
public:
static const size_t RulesBlobStrLen;
static const size_t RulesBlobSize;
Expand Down
8 changes: 7 additions & 1 deletion generated/src/aws-cpp-sdk-accessanalyzer/source/AccessAnalyzerEndpointProvider.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,15 @@
*/

#include <aws/accessanalyzer/AccessAnalyzerEndpointProvider.h>
#include <aws/accessanalyzer/internal/AccessAnalyzerEndpointRules.h>

namespace Aws {
namespace AccessAnalyzer {
namespace Endpoint {} // namespace Endpoint
namespace Endpoint {
AccessAnalyzerEndpointProvider::AccessAnalyzerEndpointProvider()
: AccessAnalyzerDefaultEpProviderBase(Aws::AccessAnalyzer::AccessAnalyzerEndpointRules::GetRulesBlob(),
Aws::AccessAnalyzer::AccessAnalyzerEndpointRules::RulesBlobSize) {}

} // namespace Endpoint
} // namespace AccessAnalyzer
} // namespace Aws
2 changes: 1 addition & 1 deletion generated/src/aws-cpp-sdk-accessanalyzer/source/AccessAnalyzerEndpointRules.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* SPDX-License-Identifier: Apache-2.0.
*/

#include <aws/accessanalyzer/AccessAnalyzerEndpointRules.h>
#include <aws/accessanalyzer/internal/AccessAnalyzerEndpointRules.h>
#include <aws/core/utils/memory/stl/AWSArray.h>

namespace Aws {
Expand Down
6 changes: 6 additions & 0 deletions generated/src/aws-cpp-sdk-account/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ file(GLOB AWS_ACCOUNT_MODEL_HEADERS
"include/aws/account/model/*.h"
)

file(GLOB AWS_ACCOUNT_INTERNAL_HEADERS
"include/aws/account/internal/*.h"
)

file(GLOB AWS_ACCOUNT_SOURCE
"source/*.cpp"
)
Expand All @@ -18,6 +22,7 @@ file(GLOB AWS_ACCOUNT_MODEL_SOURCE

file(GLOB ACCOUNT_UNIFIED_HEADERS
${AWS_ACCOUNT_HEADERS}
${AWS_ACCOUNT_INTERNAL_HEADERS}
${AWS_ACCOUNT_MODEL_HEADERS}
)

Expand All @@ -39,6 +44,7 @@ if(WIN32)
#if we are compiling for visual studio, create a sane directory tree.
if(MSVC)
source_group("Header Files\\aws\\account" FILES ${AWS_ACCOUNT_HEADERS})
source_group("Header Files\\aws\\account\\internal" FILES ${AWS_ACCOUNT_INTERNAL_HEADERS})
source_group("Header Files\\aws\\account\\model" FILES ${AWS_ACCOUNT_MODEL_HEADERS})
source_group("Source Files" FILES ${AWS_ACCOUNT_SOURCE})
source_group("Source Files\\model" FILES ${AWS_ACCOUNT_MODEL_SOURCE})
Expand Down
5 changes: 1 addition & 4 deletions generated/src/aws-cpp-sdk-account/include/aws/account/AccountEndpointProvider.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
*/

#pragma once
#include <aws/account/AccountEndpointRules.h>
#include <aws/account/Account_EXPORTS.h>
#include <aws/core/client/GenericClientConfiguration.h>
#include <aws/core/endpoint/DefaultEndpointProvider.h>
Expand Down Expand Up @@ -42,9 +41,7 @@ class AWS_ACCOUNT_API AccountEndpointProvider : public AccountDefaultEpProviderB
public:
using AccountResolveEndpointOutcome = Aws::Endpoint::ResolveEndpointOutcome;

AccountEndpointProvider()
: AccountDefaultEpProviderBase(Aws::Account::AccountEndpointRules::GetRulesBlob(),
Aws::Account::AccountEndpointRules::RulesBlobSize) {}
AccountEndpointProvider();

~AccountEndpointProvider() {}
};
Expand Down
8 changes: 7 additions & 1 deletion generated/src/aws-cpp-sdk-account/include/aws/account/Account_EXPORTS.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,13 @@
#define AWS_ACCOUNT_API
#define AWS_ACCOUNT_EXTERN extern
#endif // USE_IMPORT_EXPORT
#else // defined (USE_WINDOWS_DLL_SEMANTICS) || defined (WIN32)
#define AWS_ACCOUNT_LOCAL
#else // defined (USE_WINDOWS_DLL_SEMANTICS) || defined (WIN32)
#define AWS_ACCOUNT_API
#define AWS_ACCOUNT_EXTERN extern
#if __GNUC__ >= 4
#define AWS_ACCOUNT_LOCAL __attribute__((visibility("hidden")))
#else
#define AWS_ACCOUNT_LOCAL
#endif
#endif // defined (USE_WINDOWS_DLL_SEMANTICS) || defined (WIN32)
2 changes: 1 addition & 1 deletion ...nclude/aws/account/AccountEndpointRules.h → ...s/account/internal/AccountEndpointRules.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

namespace Aws {
namespace Account {
class AccountEndpointRules {
class AWS_ACCOUNT_LOCAL AccountEndpointRules {
public:
static const size_t RulesBlobStrLen;
static const size_t RulesBlobSize;
Expand Down
7 changes: 6 additions & 1 deletion generated/src/aws-cpp-sdk-account/source/AccountEndpointProvider.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,14 @@
*/

#include <aws/account/AccountEndpointProvider.h>
#include <aws/account/internal/AccountEndpointRules.h>

namespace Aws {
namespace Account {
namespace Endpoint {} // namespace Endpoint
namespace Endpoint {
AccountEndpointProvider::AccountEndpointProvider()
: AccountDefaultEpProviderBase(Aws::Account::AccountEndpointRules::GetRulesBlob(), Aws::Account::AccountEndpointRules::RulesBlobSize) {}

} // namespace Endpoint
} // namespace Account
} // namespace Aws
2 changes: 1 addition & 1 deletion generated/src/aws-cpp-sdk-account/source/AccountEndpointRules.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* SPDX-License-Identifier: Apache-2.0.
*/

#include <aws/account/AccountEndpointRules.h>
#include <aws/account/internal/AccountEndpointRules.h>
#include <aws/core/utils/memory/stl/AWSArray.h>

namespace Aws {
Expand Down
6 changes: 6 additions & 0 deletions generated/src/aws-cpp-sdk-acm-pca/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ file(GLOB AWS_ACM-PCA_MODEL_HEADERS
"include/aws/acm-pca/model/*.h"
)

file(GLOB AWS_ACM-PCA_INTERNAL_HEADERS
"include/aws/acm-pca/internal/*.h"
)

file(GLOB AWS_ACM-PCA_SOURCE
"source/*.cpp"
)
Expand All @@ -18,6 +22,7 @@ file(GLOB AWS_ACM-PCA_MODEL_SOURCE

file(GLOB ACM-PCA_UNIFIED_HEADERS
${AWS_ACM-PCA_HEADERS}
${AWS_ACM-PCA_INTERNAL_HEADERS}
${AWS_ACM-PCA_MODEL_HEADERS}
)

Expand All @@ -39,6 +44,7 @@ if(WIN32)
#if we are compiling for visual studio, create a sane directory tree.
if(MSVC)
source_group("Header Files\\aws\\acm-pca" FILES ${AWS_ACM-PCA_HEADERS})
source_group("Header Files\\aws\\acm-pca\\internal" FILES ${AWS_ACM-PCA_INTERNAL_HEADERS})
source_group("Header Files\\aws\\acm-pca\\model" FILES ${AWS_ACM-PCA_MODEL_HEADERS})
source_group("Source Files" FILES ${AWS_ACM-PCA_SOURCE})
source_group("Source Files\\model" FILES ${AWS_ACM-PCA_MODEL_SOURCE})
Expand Down
4 changes: 1 addition & 3 deletions generated/src/aws-cpp-sdk-acm-pca/include/aws/acm-pca/ACMPCAEndpointProvider.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
*/

#pragma once
#include <aws/acm-pca/ACMPCAEndpointRules.h>
#include <aws/acm-pca/ACMPCA_EXPORTS.h>
#include <aws/core/client/GenericClientConfiguration.h>
#include <aws/core/endpoint/DefaultEndpointProvider.h>
Expand Down Expand Up @@ -41,8 +40,7 @@ class AWS_ACMPCA_API ACMPCAEndpointProvider : public ACMPCADefaultEpProviderBase
public:
using ACMPCAResolveEndpointOutcome = Aws::Endpoint::ResolveEndpointOutcome;

ACMPCAEndpointProvider()
: ACMPCADefaultEpProviderBase(Aws::ACMPCA::ACMPCAEndpointRules::GetRulesBlob(), Aws::ACMPCA::ACMPCAEndpointRules::RulesBlobSize) {}
ACMPCAEndpointProvider();

~ACMPCAEndpointProvider() {}
};
Expand Down
8 changes: 7 additions & 1 deletion generated/src/aws-cpp-sdk-acm-pca/include/aws/acm-pca/ACMPCA_EXPORTS.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,13 @@
#define AWS_ACMPCA_API
#define AWS_ACMPCA_EXTERN extern
#endif // USE_IMPORT_EXPORT
#else // defined (USE_WINDOWS_DLL_SEMANTICS) || defined (WIN32)
#define AWS_ACMPCA_LOCAL
#else // defined (USE_WINDOWS_DLL_SEMANTICS) || defined (WIN32)
#define AWS_ACMPCA_API
#define AWS_ACMPCA_EXTERN extern
#if __GNUC__ >= 4
#define AWS_ACMPCA_LOCAL __attribute__((visibility("hidden")))
#else
#define AWS_ACMPCA_LOCAL
#endif
#endif // defined (USE_WINDOWS_DLL_SEMANTICS) || defined (WIN32)
2 changes: 1 addition & 1 deletion ...include/aws/acm-pca/ACMPCAEndpointRules.h → ...ws/acm-pca/internal/ACMPCAEndpointRules.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

namespace Aws {
namespace ACMPCA {
class ACMPCAEndpointRules {
class AWS_ACMPCA_LOCAL ACMPCAEndpointRules {
public:
static const size_t RulesBlobStrLen;
static const size_t RulesBlobSize;
Expand Down
7 changes: 6 additions & 1 deletion generated/src/aws-cpp-sdk-acm-pca/source/ACMPCAEndpointProvider.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,14 @@
*/

#include <aws/acm-pca/ACMPCAEndpointProvider.h>
#include <aws/acm-pca/internal/ACMPCAEndpointRules.h>

namespace Aws {
namespace ACMPCA {
namespace Endpoint {} // namespace Endpoint
namespace Endpoint {
ACMPCAEndpointProvider::ACMPCAEndpointProvider()
: ACMPCADefaultEpProviderBase(Aws::ACMPCA::ACMPCAEndpointRules::GetRulesBlob(), Aws::ACMPCA::ACMPCAEndpointRules::RulesBlobSize) {}

} // namespace Endpoint
} // namespace ACMPCA
} // namespace Aws
2 changes: 1 addition & 1 deletion generated/src/aws-cpp-sdk-acm-pca/source/ACMPCAEndpointRules.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* SPDX-License-Identifier: Apache-2.0.
*/

#include <aws/acm-pca/ACMPCAEndpointRules.h>
#include <aws/acm-pca/internal/ACMPCAEndpointRules.h>
#include <aws/core/utils/memory/stl/AWSArray.h>

namespace Aws {
Expand Down
Loading
Loading