CborShapeSerializer#3871
Merged
Merged
Conversation
pulimsr
marked this pull request as ready for review
July 21, 2026 14:26
sbiscigl
reviewed
Jul 21, 2026
sbiscigl
reviewed
Jul 21, 2026
| m_encoder.WriteText(Aws::Crt::ByteCursorFromArray(reinterpret_cast<const uint8_t*>(value.data()), value.size())); | ||
| } | ||
|
|
||
| void WriteTimestamp(const Schema& schema, const DateTime& value) { |
Collaborator
There was a problem hiding this comment.
we should prolly keep this like the way we had it initially i.e. from the protocol test
just so that we are not changing the wire format at all and using what we did before. so this would become
void WriteTimestamp(const Schema& schema, const DateTime& value) {
WriteFieldName(schema);
encoder.WriteTag(1);
encoder.WriteUInt(item_0.Seconds());
}this way it stays exactly the same
| private: | ||
| Aws::Crt::Cbor::CborEncoder m_encoder; | ||
| int m_depth = 0; | ||
| Aws::Array<bool, MAX_DEPTH> m_isMap{}; |
Collaborator
There was a problem hiding this comment.
they already bounds check for us so i would just remove all bounds checking logic and fall back to theirs. also then we save logic and space on the object
sbiscigl
approved these changes
Jul 22, 2026
pulimsr
enabled auto-merge
July 22, 2026 17:43
pulimsr
disabled auto-merge
July 22, 2026 20:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.