fix(otel): correct exported status mappings - #752
Open
zhongkechen wants to merge 1 commit into
Open
zhongkechen wants to merge 1 commit into
zhongkechen wants to merge 1 commit into
Conversation
Contributor
Codex AI reviewNo actionable findings. Coverage spans both OTel plugin views; residual risk is limited to exporter-specific behavior not exercised in a deployed environment. Reviewed commit |
This was referenced Oct 2, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #750.
Both OTel views now reserve operation
OKforSUCCEEDED. Cancelled, timed-out, stopped and failed outcomes without error details stayUNSET; delivered error details still produceERRORand the existing exception event. Retry invocations exportdurable.invocation.status=RETRYINGwhile the coreInvocationStatus.RETRYAPI is unchanged. The OTel README documents these attribute corrections.Validation: 292 OTel tests pass, including 42 new cases across both views for terminal statuses with/without errors, operations started in this or a previous invocation, and retry followed by resume with context restoration. The new tests reproduce 18 failures on unmodified main.
hatch run dev-otel:typecheck, packagehatch fmt --check, andgit diff --checkpass. Tests use real OTel providers/exporters in process; no cloud deployment was run. Shared conformance status requirements can be coordinated separately.Based directly on main; independent of the breaking plugin-factory migration in #737.