fix(cli): don't re-run listeners when replaying corked messages#1701
Merged
Conversation
Messages emitted while corked are buffered and later replayed through notify() when the cork releases. notify() re-ran the message listeners on that replay, so a listener that transforms a message (e.g. a rewrite) ran a second time on its own output. Skip applyMessageListeners while corkReplaying, matching the existing guard that already skips observers. One unit test on CliIoHost proving a rewrite fires once through cork replay.
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1701 +/- ##
=======================================
Coverage 89.62% 89.62%
=======================================
Files 77 77
Lines 11746 11752 +6
Branches 1649 1650 +1
=======================================
+ Hits 10527 10533 +6
Misses 1190 1190
Partials 29 29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
otaviomacedo
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Messages emitted while logging is corked are buffered and replayed through
notify()when the cork releases.notify()re-ran the message listeners on that replay, so a listener that transforms a message (e.g. arewrite) ran a second time on its own already-transformed output.This skips
applyMessageListenerswhilecorkReplaying, matching the existing guard that already skips observers on replay. Listeners now run exactly once, on the first pass.The visible case: under
--yes, the auto-confirm suffix is added (viawriteMessage) after listeners run, while corked. On replay, arewritelistener on that request code would clobber the suffix. This is latent onmaintoday (nothing registers such a listener yet) but blocks thecdk deployreroute in #1585.Test plan
test/cli/io-host/cli-io-host.test.ts: arewritelistener fires once through a corked replay, not again on the replayed message. Verified it fails without the fix (listener runs twice) and passes with it.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license