Skip to content

fix: agent-inspector frontend assets missing from build#883

Merged
aidandaly24 merged 2 commits intoaws:mainfrom
avi-alpert:aalpert/fix-inspector-assets
Apr 17, 2026
Merged

fix: agent-inspector frontend assets missing from build#883
aidandaly24 merged 2 commits intoaws:mainfrom
avi-alpert:aalpert/fix-inspector-assets

Conversation

@avi-alpert
Copy link
Copy Markdown
Contributor

@avi-alpert avi-alpert commented Apr 17, 2026

Description

  • Ran npm i to update package-lock.json to use npm as source for @aws/agent-inspector
  • Update build script to fail CI instead of just warn when @aws/agent-inspector assets fail to copy

Related Issue

Closes #

Documentation PR

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Testing

How have you tested the change?

  • I ran npm run test:unit and npm run test:integ
  • I ran npm run typecheck
  • I ran npm run lint
  • If I modified src/assets/, I ran npm run test:update-snapshots and committed the updated snapshots

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.

@avi-alpert avi-alpert requested a review from a team April 17, 2026 16:04
@github-actions github-actions bot added the size/xs PR size: XS label Apr 17, 2026
@avi-alpert avi-alpert force-pushed the aalpert/fix-inspector-assets branch from 691a63a to 0330962 Compare April 17, 2026 16:07
@github-actions github-actions bot added size/xs PR size: XS and removed size/xs PR size: XS labels Apr 17, 2026
@avi-alpert avi-alpert force-pushed the aalpert/fix-inspector-assets branch from 0330962 to 96e6e60 Compare April 17, 2026 16:13
@github-actions github-actions bot added size/xs PR size: XS and removed size/xs PR size: XS labels Apr 17, 2026
jesseturner21
jesseturner21 previously approved these changes Apr 17, 2026
- Wrap onReadyRef update in useEffect to avoid ref mutation during render
- Replace loggerRef.current access in return object with logFilePath state
- Replace useEffect+setState with state-based prev-step tracking pattern

Confidence: high
Scope-risk: narrow
@github-actions
Copy link
Copy Markdown
Contributor

Package Tarball

aws-agentcore-0.9.0.tgz

How to install

npm install https://github.com/aws/agentcore-cli/releases/download/pr-883-tarball/aws-agentcore-0.9.0.tgz

@aidandaly24 aidandaly24 merged commit 08f826c into aws:main Apr 17, 2026
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s PR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants