fix(monitoring): Migrate Grafana to grafana-community chart and fix PVC deadlock#927
Merged
Merged
Conversation
added 2 commits
July 3, 2026 17:07
The grafana chart in grafana.github.io/helm-charts is now deprecated (frozen at chart 10.5.15 / Grafana 12.3.1, marked deprecated: true) after Grafana Labs forked the charts to grafana-community/helm-charts on March 16, 2026. Installs emit "WARNING: This chart is deprecated". Point the grafana chart at the maintained community repo (grafana-community/grafana, chart 12.7.2 / Grafana 13.1.0) in both monitoring.sh and perf-platform.sh. All values keys used by the scripts (admin, service, persistence, resources, sidecar, plugins, grafana.ini) remain valid in the new chart. The pyroscope chart was not moved, so perf-platform.sh keeps the original grafana repo alongside the new grafana-community repo for grafana/pyroscope.
The Grafana chart defaults to deploymentStrategy RollingUpdate, but the workshop enables persistence on a gp3 EBS volume (ReadWriteOnce). On the plugin upgrade in perf-platform.sh, RollingUpdate starts a new pod before deleting the old one; the new pod cannot attach the RWO volume still held by the old pod, so it hangs with a Multi-Attach error until helm --wait hits its deadline (UPGRADE FAILED: context deadline exceeded at line 292). Set deploymentStrategy.type: Recreate in the Grafana values so the old pod is terminated first and releases the volume. The value is persisted on the release, so perf-platform.sh picks it up via --reuse-values. Also raise the plugin-install --timeout from 5m to 10m to allow for the EBS detach/reattach cycle plus plugin download on the Recreate path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the workshop bootstrap failure in the performance-platform setup, where Grafana could not be installed/upgraded via Helm. Two independent root causes, both in the setup scripts (
infra/scripts/setup/monitoring.shandinfra/scripts/setup/perf-platform.sh):Deprecated Helm chart. As of March 16, 2026 Grafana Labs forked their Helm charts to
grafana-community/helm-charts. Thegrafanachart in the oldgrafana.github.io/helm-chartsrepo is nowdeprecated: trueand frozen at chart10.5.15(Grafana 12.3.1), so installs printedWARNING: This chart is deprecated.PVC deadlock on upgrade. The chart defaults to
deploymentStrategy: RollingUpdate, but the workshop enables persistence on agp3EBS volume (ReadWriteOnce). On the plugin upgrade inperf-platform.sh, RollingUpdate starts the new pod before deleting the old one; the new pod cannot attach the RWO volume still held by the old pod, so it hangs untilhelm --waithits its deadline:UPGRADE FAILED: context deadline exceeded.Changes
grafanachart at the maintained community repografana-community/grafana(chart12.7.2/ Grafana13.1.0) in both scripts.grafanarepo inperf-platform.shforgrafana/pyroscope, which was not moved to the community repo.deploymentStrategy.type: Recreatein the Grafana values so the old pod is torn down first and releases the EBS volume. Persisted on the release, soperf-platform.shinherits it via--reuse-values.--timeoutfrom5mto10mto cover the EBS detach/reattach cycle plus plugin download on the Recreate path.Verification
grafanachart isdeprecated: trueand the community repo serves an activegrafanachart (12.7.2).pyroscopestill resolves only from the old repo.admin.existingSecret/userKey/passwordKey,service,persistence,resources,sidecar.dashboards/datasources,plugins,grafana.ini) exists in the community12.7.2chart.bash -npasses on both scripts. CI green (the one flaky failure was a transient Maven Central 403 onspring-boot-starter-parent:4.1.0, unrelated to these changes; cleared on re-run).