Fix nested secrets and names conversion#692
Fix nested secrets and names conversion#692visit1985 wants to merge 2 commits intoaws-controllers-k8s:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: visit1985 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @visit1985. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issue #, if available:
This PR is related to aws-controllers-k8s/community#2813.
During my attempt to generate the ack-dms-controller, I identified the following problems:
SASLPassword,SSLClientKeyPassword) could not be found inMemberFieldsmap because the lookup used raw AWS SDK names (SaslPassword,SslClientKeyPassword) while the map is keyed by normalized camelCase names.is_secret: trueconfiguration.Description of changes:
is_secret: trueautomatically suppress SDK→CRD output setters.Sasl→SASL) no longer causes member field lookup failures.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.