fix: unify cron job commands and remove redundant path handling - #654
Merged
Conversation
avoidwork
force-pushed
the
fix/cron-job-command-and-path
branch
2 times, most recently
from
July 31, 2026 00:15
f97f098 to
9ccdc73
Compare
- Replace --chat with --message flag across all cron job definitions - Remove hardcoded 'run /reflection' in favor of --message - Remove unnecessary node path replacement (node is in PATH) - Remove log redirection (>>) from prepareCrontabCommand - Update persisted reflection-daily.json to match new command format - Update tests to reflect new prepareCrontabCommand behavior - Read schedulesDir from config instead of hardcoding in autoSchedule.js
avoidwork
force-pushed
the
fix/cron-job-command-and-path
branch
from
July 31, 2026 00:34
9ccdc73 to
5f4b61c
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Unify cron job command definitions across the codebase and remove redundant path handling. Replaces
--chatwith--messageflag, removes hardcoded"run /reflection"strings, removes unnecessary node path replacement, and removes log redirection fromprepareCrontabCommand.Type of Change
Testing
tests/unit/scheduler/cron.test.jsto reflect newprepareCrontabCommandbehavior (no longer appends>>log redirection or replacesnodewith absolute path)tests/unit/autoSchedule.test.jsto expect--messageflag instead of"run /reflection"Coverage
Checklist
npm run lintpasses