feature: FGI-1574 add connected account support#67
Conversation
|
|
||
| # Extract the returnTo URL from the appState if available. | ||
| return_to = session_data.get("app_state", {}).get("returnTo") | ||
| return_to = app_state.get("returnTo") |
There was a problem hiding this comment.
Not the fault of this PR, but this SDK should have something like this https://github.com/auth0/nextjs-auth0/blob/main/EXAMPLES.md#oncallback-hook - otherwise the api response gets lost
There was a problem hiding this comment.
Yeh I struggled with what to do after completion. I thought this was the best option for expediency to get something functional for the GA date as there's not actually a lot thats useful in the response. This SDK is pretty bare feature wise though compared to the JS SDK. I can add something like this in in a follow up PR
|
Claude finished @sam-muncke's task —— View job Code Review Complete
Overall Assessment❌ This PR has critical security and correctness issues that must be addressed before merging. The most significant concern is an open redirect vulnerability in the callback handler where the |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
… mutually exclusive with legacy connect behaviour
sam-muncke
changed the title
sam-muncke
changed the title
4 participants
Changes
This change adds support for the new Connected Accounts flow.
--
mount_connected_account_routes- Adds the/auth/connectroute and allows/auth/callbackto handle the connected account callback/auth/connectroute to initiate connected account flow/auth/callbackto handle connected account callback to complete the flow if theconnect_codeparam is presentNote: This change depends on the functionality in [this PR]:auth0/auth0-server-python#57 and requires a version bump to
auth0-server-pythonlib.References
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
Checklist