ci: pin Bun to 1.3.11 to fix codesign regression#122
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review Triage 🛡️ · Low Risk
✅ Approved — Low-Risk Change
Justification
This PR adds exactly 2 lines to a CI workflow file (.github/workflows/bun-compile.yml) to pin oven-sh/setup-bun@v2 to bun-version: "1.3.11". No source code, tests, or runtime behavior are affected. The change is a straightforward version pin to work around a known upstream regression in Bun 1.3.12's Mach-O output that broke codesign on darwin-arm64. The author verified the fix by manually triggering the workflow on this branch.
👍 / 👎 Was this triage helpful? React to this comment with your feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pins Bun to version 1.3.11 in the
bun-compileworkflow to fix thecodesignfailure ondarwin-arm64binaries.Problem
Starting with run #104, the "Sign binary" step consistently fails on
darwin-arm64with:The workflow file had not changed — the breakage was caused by Bun v1.3.12 (released April 9, 2026) being picked up automatically by
oven-sh/setup-bun@v2. The previous run (#103) succeeded with Bun 1.3.11 just hours earlier.Bun 1.3.12 includes a large JSC engine upgrade (1,650+ commits) and changes to standalone executable embedding that appear to have regressed the Mach-O layout of
bun build --compile --target=bun-darwin-arm64output, making it unsignable bycodesign.Fix
Pin
oven-sh/setup-bun@v2tobun-version: "1.3.11"so the workflow uses a known-good Bun version.Verification
Manually triggered the workflow from this branch with version
0.24.0-prerelease.5(the same version that failed onmain) — all jobs passed, includingdarwin-arm64codesign and notarization.