Improve provisioning error reporting and fix logging on esp32 heltec tracker v2#72
Open
evelant wants to merge 2 commits into
Open
Improve provisioning error reporting and fix logging on esp32 heltec tracker v2#72evelant wants to merge 2 commits into
evelant wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few small things I found while adding support for the Heltec Tracker V2 #71
StorageErrorwhen a wire-protocol commit cannot persist its promoted state.%llusupport varies (%llu formatting crashes on the heltec tracker v2).Previously, the wire commit path discarded the result of
save_namespace(), allowing clients to believe a configuration was safely committed even when its namespace file could not be written.