Esp32/usb cdc tinyusb 2.0#2339
Draft
petermm wants to merge 1 commit into
Draft
Conversation
The USB CDC code targeted the deprecated esp_tinyusb 1.x API, but CI pulls in esp_tinyusb ^2.0.0. Migrate to the canonical 2.0.0 names so the driver and console build against the dependency actually installed: - tusb_cdc_acm_init/deinit -> tinyusb_cdcacm_init/deinit - esp_tusb_init_console -> tinyusb_console_init - tusb_cdc_acm.h/tusb_console.h headers -> tinyusb_* headers Link esp_tinyusb in avm_builtins whenever the managed component is present instead of gating on IDF >= 5.3. esp_tinyusb 2.0.0 supports IDF >= 5.0, and the old guard left the usb_cdc_driver.c TinyUSB includes unsatisfied on IDF 5.2, breaking the build. Emit a clear FATAL_ERROR if the component is missing rather than failing later on a missing header. Stop shadowing the managed component's TINYUSB_CDC_ENABLED symbol: the AtomVM USB options now select it instead of redefining/depending on it, which also lets CI enable USB CDC with a single sdkconfig entry. Add IDF v5.2.7 usb-serial and usb-cdc jobs to the ESP32 CI matrix to cover the lowest supported esp_tinyusb 2.0.0 IDF version. Signed-off-by: Peter M <petermm@gmail.com>
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2337
Only draft as I need to test it more thoroughly..
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later