feat: add rn logging of native debug events#103
Merged
brax10ward merged 1 commit intomasterfrom Apr 10, 2026
Merged
Conversation
6ddc91c to
4b68f6a
Compare
brax10ward
commented
Apr 10, 2026
| func presentTransact(config: [String: Any], environment: [String: Any], presentationStyle: String?, setDebug: NSNumber?, resolve: @escaping RCTPromiseResolveBlock, reject: @escaping RCTPromiseRejectBlock) -> Void { | ||
| let debugEnabled = setDebug?.boolValue ?? false | ||
|
|
||
| Task { @MainActor in |
Contributor
Author
There was a problem hiding this comment.
@eriksargent this is the biggest change that was made. Just wanted to double check that this is going to be ok to switch from DispatchQueue.main.async
eriksargent
approved these changes
Apr 10, 2026
| func presentTransact(config: [String: Any], environment: [String: Any], presentationStyle: String?, setDebug: NSNumber?, resolve: @escaping RCTPromiseResolveBlock, reject: @escaping RCTPromiseRejectBlock) -> Void { | ||
| let debugEnabled = setDebug?.boolValue ?? false | ||
|
|
||
| Task { @MainActor in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear Link
https://linear.app/atomicbuilt/issue/SDK-289/setup-debug-flag-in-react-native-sdk-for-ios
Type of change
Checklist: