Allow providing additional parameters with a search#57
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for passing additional query parameters to OpenSearch search requests through the existing Search object.
Changes:
- Adds parameter storage and retrieval to
Search. - Adds OpenSearch URL construction with encoded query parameters.
- Applies the additional parameters when executing
_searchrequests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/Search/Search.php |
Extends the search value object to carry additional query parameters. |
src/Driver/OpenSearch/OpenSearch.php |
Appends search parameters to OpenSearch _search request URLs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
matthi4s
approved these changes
May 29, 2026
KurtThiemann
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR, you can add additional query parameters to the search. For opensearch these are documented here: https://docs.opensearch.org/latest/api-reference/search-apis/search/