fix: correctly get file extension for multi-dot filenames like my.asyncapi.yaml#2208
Open
hikali123456789 wants to merge 2 commits into
Open
fix: correctly get file extension for multi-dot filenames like my.asyncapi.yaml#2208hikali123456789 wants to merge 2 commits into
hikali123456789 wants to merge 2 commits into
Conversation
|
2 tasks
Author
|
Hi! This PR is ready for review. The fix handles multi-dot filenames correctly. Let me know if any changes needed. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
The ileExists() function in SpecificationFile.ts incorrectly extracts file extensions using split('.')[1], which only works for single-dot filenames like ile.txt but fails for multi-dot filenames like my.asyncapi.yaml.
Example
Fix
Changed the extension extraction logic to use slice(1).join('.') which correctly captures all parts after the first dot, or to use lastIndexOf('.') approach to get the last extension.
PR-Merge
Please add the �ounty label and the shipit / hacktoberfest-accepted label if applicable. Thank you!