Fix #[track_caller] for .success(), .failure(), and more#289
Open
marcospb19 wants to merge 1 commit intoassert-rs:masterfrom
Open
Fix #[track_caller] for .success(), .failure(), and more#289marcospb19 wants to merge 1 commit intoassert-rs:masterfrom
#[track_caller] for .success(), .failure(), and more#289marcospb19 wants to merge 1 commit intoassert-rs:masterfrom
Conversation
marcospb19
commented
Apr 29, 2026
epage
reviewed
Apr 29, 2026
| /// # Panic | ||
| /// | ||
| /// Panicks if no binary is found | ||
| #[track_caller] |
Contributor
There was a problem hiding this comment.
This seems uncommon enough and with enough context that it might not be needed
Contributor
|
Yeah, that is really annoying situation with combinators. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
ouchI've long had the problem of.success()and.failure()giving me a panic that happened at$HOME/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ops/function.rs:250:5.Running this you get:
So in this PR I fix the function wrapping that prevented
#[track_caller]from working, here is what it looks like now:I also added a bunch of
#[track_caller]at places where there is a panic path, let me know if you think that's excessive.