fix: apply transformations to exprs in events#288
Closed
b-fein wants to merge 1 commit into
Closed
Conversation
b-fein
changed the title
Fixes aspizu#285 So far constant-folding was only applied to expressions appearing in statements. However, the OnLoudnessGt and OnTimerGt event types also contain expressions. In case of negative number literals this resulted in a crash when generating the Scratch code, since such numbers are represented as `Unop(Minus, 2)` in the Goboscript AST whereas they are direct literals `-2` in Scratch and thus no opcode for Minus exists.
b-fein
force-pushed
the
fix-constant-folding-in-events
branch
from
117d0d2 to
cecbad7
Compare
Owner
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #285
So far constant-folding was only applied to expressions appearing in statements. However, the OnLoudnessGt and OnTimerGt event types also contain expressions.
In case of negative number literals this resulted in a crash when generating the Scratch code, since such numbers are represented as
Unop(Minus, 2)in the Goboscript AST whereas they are direct literals-2in Scratch and thus no opcode for Minus exists.I am unsure if this fix is complete or if the event-exprs should also be visited in some of the other passes. At least for the minimal example from the issue it now works.