[codex] Preserve craft-spaces wildcard domain#287
Merged
Conversation
|
Deployment failed with the following error: Learn More: https://vercel.link/3Fpeeb1 |
Contributor
There was a problem hiding this comment.
Pull request overview
Ensures the production Dokku deployment keeps craft-spaces.bricks.cool and *.craft-spaces.bricks.cool bound to the bricks app so generated channel sites under https://<slug>.craft-spaces.bricks.cool/ continue to route correctly across deploys, while documenting the wildcard-host requirement and recording the production fix.
Changes:
- Update the production Dokku deploy workflow to set the app domains to include
craft-spaces.bricks.cooland the wildcard*.craft-spaces.bricks.cool. - Document the wildcard-host requirement (and origin SNI/TLS implication) in Dokku deployment docs.
- Add a completed task record describing the incident, acceptance criteria, and validation.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/tasks/done/2026-07-03-19-22-CST-craft-spaces-wildcard-origin-tls.md | Records the completed production fix and validation evidence/commands. |
| docs/deploy/dokku.md | Documents required Dokku domain bindings for generated channel site wildcard hosts. |
| .github/workflows/dokku_production_deploy.yml | Preserves the wildcard craft-spaces domain bindings during production deploy provisioning. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
42
to
+45
| app="bricks" | ||
| data_root="/home/bricks/data/production/sandboxes" | ||
| domain="craft.bricks.cool" | ||
| public_site_domain="craft-spaces.bricks.cool" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation