fix: handle removal of :context multitenancy in migrations#752
Open
Ryan6794 wants to merge 2 commits into
Open
fix: handle removal of :context multitenancy in migrations#752Ryan6794 wants to merge 2 commits into
Ryan6794 wants to merge 2 commits into
Conversation
Contributor
|
Could we add a test for this too? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Leave anything that you believe does not apply unchecked.
When a resource transitions from :context multitenancy to global?: true (or removing multitenancy entirely), the migration generator produces an invalid migration that tries to drop a foreign key constraint that doesn't exist yet.
Bugs:
Wrong snapshot folder lookup - :context snapshots are stored in tenants/ but after removing multitenancy the code looks in the base folder. The old snapshot is not found so the table is treated as brand new.
Incorrect FK drop generated - has_reference?/2 did not account for the case where both the table and the referenced resource previously had :context multitenancy. Since the FK was never created in the global schema, it should not be dropped.
Fix:
Testing:
Reproduced using the demo repo linked in the issue: https://github.com/serpent213/ash_postgres_multitenancy_migration_demo
After the fix, all three steps complete successfully: