fix: make loadTrack reconcile track metadata#14
Open
jeryj wants to merge 1 commit into
Open
Conversation
32bc2b9 to
4449fb5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
loadTrack()a complete in-place track swap for per-track metadata.Previously, consumers could update the audio source with
loadTrack(), but artist and artwork DOM could only be updated when the relevant elements already existed. If a new track added or removed artist/artwork metadata, consumers had to destroy and recreate the player to get the DOM into the right shape.This updates
loadTrack()to reconcile those fields in place:artworkAltis suppliedWhy
This lets consumers switch tracks without tearing down the player instance when metadata presence changes, avoiding unnecessary DOM churn and visible layout shifts.
Testing
npm testnpm run buildCo-authored-by: Codex codex@openai.com