Fix WiFi SSIDs with spaces missing from scan list - #4634
Merged
Conversation
The wpa_cli scan_results puts the SSID last, splitting on all whitespace dropped any network whose name contained spaces.
1 task
svartkanin
approved these changes
Jul 27, 2026
Collaborator
|
Thank you for adding tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description:
WifiNetwork.from_wpausedline.split()and required exactly 5 fields. SSIDs with spaces produced more tokens and were dropped silently, so they never appeared in the TUI list.split(None, 4)so the SSID is the remainder (spaces preserved)Unit tests cover SSIDs with and without spaces, empty SSID, header/blank line skip, and field preservation.
Tests and Checks