Remove dead code and tighten parameter validation#77
Open
apstndb wants to merge 1 commit into
Open
Conversation
Drop unused debug logging and redundant trace cancel wiring so shutdown stays explicit, and reject non-finite floats in param files early. Co-authored-by: Cursor <cursoragent@cursor.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes unused debug logging and simplifies tracing initialization by removing the traceCancel context cancellation function from enableTracing. Additionally, it updates parameter float formatting to explicitly reject non-finite float values (NaN and infinity) with an error, and adds corresponding unit tests to verify this behavior. I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
debuglogglobal andinit()block frommain.go.enableTracingby dropping the redundantcontext.WithCancellayer; shutdown already uses a separate timeout context.Part of #74.
Test plan
make lintmake test(including new param-file non-finite float tests)Made with Cursor