Remove dead jqresult API surface left over from input-mode split#76
Remove dead jqresult API surface left over from input-mode split#76apstndb wants to merge 1 commit into
Conversation
Compile never used its mode argument, NormalizeForEncode had a no-op branch, and runJqOutput's read-write case was unreachable after eager materialization was forced for DML. Co-authored-by: Cursor <cursoragent@cursor.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request simplifies the jqresult.Compile function by removing the unused InputMode parameter and updating all its call sites across tests and main execution paths. Additionally, it cleans up jqresult/normalize.go by removing unused imports and the redundant isEncodeLeaf helper function, as the default switch case already handles those types identically. In main.go, a redundant panic case for readWrite mode has been removed and replaced with an explanatory comment. I have no further feedback to provide as the changes are clean and simplify the codebase.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
1 participant
Summary
modeparameter fromjqresult.Compileand update all call sites.NormalizeForEncodeby removing the redundantisEncodeLeafbranch.readWritecase inrunJqOutputand document that read-write DML always uses eager jq materialization.Part of #74.
Test plan
make lintmake test(including emulator integration tests)Made with Cursor