Tighten CLI logging and jq option validation#72
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
There was a problem hiding this comment.
Code Review
This pull request refactors command-line flag validation, introduces configurable gRPC logging modes (off, metadata, payload), and adds unit tests for flag validation and query mode detection. Feedback on the changes includes handling potential errors from zapDevelopmentConfig.Build to prevent nil pointer panics, and adding client-side validation to ensure --try-partition-query and --read-timestamp are not used with DML statements.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors flag validation and introduces configurable gRPC logging options (off, metadata, payload) to replace the previous boolean flag. It extracts validation logic into dedicated helper functions, adds a comprehensive test suite in flags_validation_test.go, and updates the Makefile and README.md. The reviewer feedback suggests minor code simplifications, including removing a redundant zap.Fields() call when building the logger and omitting struct tags in anonymous struct initializations within the test suite to improve readability.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces configurable gRPC logging modes (off, metadata, payload), refactors flag validation logic into dedicated helper functions, and adds comprehensive unit tests in flags_validation_test.go. The Makefile and README.md have also been updated to reflect these changes. The review feedback suggests validating the --strong flag against DML statements, reordering the validation checks in validateJqOutputOptions to produce more specific error messages, and updating the corresponding test cases to match.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors command-line flag validation and introduces configurable gRPC logging modes (off, metadata, payload) to replace the previous boolean flag. It extracts validation logic for execution and JQ output options, query mode detection, and timestamp parsing into dedicated helper functions. Additionally, a comprehensive test suite has been added in flags_validation_test.go, and both the Makefile and README.md have been updated to reflect these changes. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Summary
--log-grpcto an explicitoff|metadata|payloadmode so payload logging requires an intentional opt-in.Closes #58.
Closes #59.
Closes #60.
Closes #61.
Closes #62.
Closes #63.
Validation
git diff --checkgo test ./params/... ./jqresult/... ./resultset/...go test .make buildmake lintmake test