Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
127 changes: 127 additions & 0 deletions specs/latest/open-api3-latest-client.json
Original file line number Diff line number Diff line change
Expand Up @@ -4339,6 +4339,44 @@
"type": "string"
}
},
"tagline": {
"type": "string",
"description": "Application tagline shown to users during OAuth2 consent.",
"default": "",
"x-example": "<TAGLINE>"
},
"tags": {
"type": "array",
"description": "Application tags shown to users during OAuth2 consent. Maximum of 100 tags are allowed, each up to 64 characters long.",
"default": [],
"x-example": null,
"items": {
"type": "string"
}
},
"images": {
"type": "array",
"description": "Application image URLs shown to users during OAuth2 consent. Maximum of 100 images are allowed.",
"default": [],
"x-example": null,
"items": {
"type": "string"
}
},
Comment on lines +4357 to +4365

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 images items missing format: "url" annotation

The images array items are typed as plain "type": "string" without a "format": "url" annotation, while the two sibling scalar URL fields supportUrl and dataDeletionUrl in the same request schema both carry "format": "url". SDK generators and validators that respect the format keyword will enforce URL format for those scalars but not for individual image entries. The same inconsistency appears in the update-operation block (~line 4615), and is repeated in the equivalent positions in open-api3-latest-console.json and open-api3-latest-server.json.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

"supportUrl": {
"type": "string",
"description": "Application support URL shown to users during OAuth2 consent.",
"default": "",
"x-example": "https:\/\/example.com",
"format": "url"
},
"dataDeletionUrl": {
"type": "string",
"description": "Application data deletion URL shown to users during OAuth2 consent.",
"default": "",
"x-example": "https:\/\/example.com",
"format": "url"
},
"redirectUris": {
"type": "array",
"description": "Redirect URIs (array of valid URLs).",
Expand Down Expand Up @@ -4559,6 +4597,44 @@
"type": "string"
}
},
"tagline": {
"type": "string",
"description": "Application tagline shown to users during OAuth2 consent.",
"default": "",
"x-example": "<TAGLINE>"
},
"tags": {
"type": "array",
"description": "Application tags shown to users during OAuth2 consent. Maximum of 100 tags are allowed, each up to 64 characters long.",
"default": [],
"x-example": null,
"items": {
"type": "string"
}
},
"images": {
"type": "array",
"description": "Application image URLs shown to users during OAuth2 consent. Maximum of 100 images are allowed.",
"default": [],
"x-example": null,
"items": {
"type": "string"
}
},
"supportUrl": {
"type": "string",
"description": "Application support URL shown to users during OAuth2 consent.",
"default": "",
"x-example": "https:\/\/example.com",
"format": "url"
},
"dataDeletionUrl": {
"type": "string",
"description": "Application data deletion URL shown to users during OAuth2 consent.",
"default": "",
"x-example": "https:\/\/example.com",
"format": "url"
},
"enabled": {
"type": "boolean",
"description": "Is application enabled?",
Expand Down Expand Up @@ -19749,6 +19825,42 @@
"support@example.com"
]
},
"tagline": {
"type": "string",
"description": "Application tagline shown to users during OAuth2 consent.",
"x-example": "Automate your workspace."
},
"tags": {
"type": "array",
"description": "Application tags shown to users during OAuth2 consent.",
"items": {
"type": "string"
},
"x-example": [
"productivity",
"automation"
]
},
"images": {
"type": "array",
"description": "Application image URLs shown to users during OAuth2 consent.",
"items": {
"type": "string"
},
"x-example": [
"https:\/\/example.com\/screenshot.png"
]
},
"supportUrl": {
"type": "string",
"description": "Application support URL shown to users during OAuth2 consent.",
"x-example": "https:\/\/example.com\/support"
},
"dataDeletionUrl": {
"type": "string",
"description": "Application data deletion URL shown to users during OAuth2 consent.",
"x-example": "https:\/\/example.com\/data-deletion"
},
"redirectUris": {
"type": "array",
"description": "List of authorized redirect URIs. These URIs can be used to redirect users after they authenticate.",
Expand Down Expand Up @@ -19804,6 +19916,11 @@
"privacyPolicyUrl",
"termsUrl",
"contacts",
"tagline",
"tags",
"images",
"supportUrl",
"dataDeletionUrl",
"redirectUris",
"enabled",
"type",
Expand All @@ -19825,6 +19942,16 @@
"contacts": [
"support@example.com"
],
"tagline": "Automate your workspace.",
"tags": [
"productivity",
"automation"
],
"images": [
"https:\/\/example.com\/screenshot.png"
],
"supportUrl": "https:\/\/example.com\/support",
"dataDeletionUrl": "https:\/\/example.com\/data-deletion",
"redirectUris": [
"https:\/\/example.com\/callback"
],
Expand Down
Loading