fix(cli): pass fallbackFile and VCS fields through push sites - #1687
Merged
Conversation
push sites ignored SPA fallbackFile and git connection fields from appwrite.config.json even though sites create/update already accept them. Pass them through on create/update, allow them in the site config schema, and include them when pulling sites so config round-trips. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Greptile SummaryThis PR restores site configuration round-tripping in the generated CLI.
Confidence Score: 5/5The PR appears safe to merge, with the new fields consistently represented across configuration validation, pull, and both push paths. The changes propagate matching optional site properties through the complete config round-trip without introducing a concrete build, runtime, data-integrity, or security failure. Important Files Changed
Reviews (1): Last reviewed commit: "fix(cli): pass fallbackFile and VCS fiel..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
appwrite push sitesdropsfallbackFileand git/VCS fields from create/update payloads, so values inappwrite.config.jsonare ignored even thoughsites create/sites updatealready accept them.This updates the CLI templates so generated sdk-for-cli:
fallbackFile,installationId,providerRepositoryId,providerBranch,providerSilentMode, andproviderRootDirectoryon both create and update inpushSitesOriginally reported in appwrite/sdk-for-cli#344. A direct fix to sdk-for-cli (#345) was closed in favor of landing this in sdk-generator.
Test plan
fallbackFile: "index.html"on a site inappwrite.config.jsonappwrite push sites --site-id <id> --forceappwrite sites get --site-id <id>and confirmfallbackFileis setinstallationId/providerRepositoryId/providerBranch/providerRootDirectory/providerSilentModeand confirm they are applied on pushappwrite pull siteswrites those fields back into the config