feat: PHP SDK update for version 26.0.0#79
Conversation
Greptile Summary
Confidence Score: 4/5The SDK update is mostly generated and consistent, but resumable storage uploads need attention before merge. Most changed service surfaces, models, enums, docs, and tests align with the described API update; the remaining issue is isolated to resumed large-file uploads. src/Appwrite/Services/Storage.php
What T-Rex did
|
|
@greptile-apps re: "Omit null transactions" (P1, TablesDB/Databases write methods) — verified this is accurate as a description but not a defect. It is the same class as the "Omit null optionals" thread on Mechanism (from the spec):
Why it is safe: because the write field is This is generator-faithful behavior, not an SDK bug — nothing to change in the generated code. If the read/write inconsistency is undesirable cosmetically, the fix is a spec change (model the write-body (Separately, the earlier "Chunk uploads skip accept" finding is now resolved — the latest push regenerates with sdk-generator 2.0.2+, which adds the |
|
Thanks for the thorough breakdown — both points are well-reasoned and I agree with the conclusions. Omit null transactions: The distinction is clear. Chunk uploads / accept header: Confirmed resolved — the regeneration with sdk-generator 2.0.2+ covers this. Nothing left to address. Tip: You can customize Greptile's behavior for this repo with |
|
@greptile-apps re: "Add accept headers" (P1, The flagged methods all return 204 No Content with no declared
The generator derives the So this is consistent, by-design behavior, not the gap this PR addresses (the real chunked-upload |
|
That's a clear and well-reasoned explanation — thanks for the table. The generator's behavior is correct: no No issues on my end. This is fine as-is. |
This PR contains updates to the SDK for version 26.0.0.
What's Changed
osCode,clientName,deviceModel, etc.) fromActivityEventauthorizationDetailsTypesmid-signature inproject.updateOAuth2SerververificationUrl,userCodeLength,userCodeFormat, anddeviceCodeDurationtoupdateOAuth2ServerupdateDenyCorporateEmailPolicyandPolicyDenyCorporateEmailtoprojectdeny-corporate-emailtoProjectPolicyIdoauth2toProjectServiceIdanddedicatedDatabases.executetoProjectKeyScopesemailCanonical,emailIsFree,emailIsDisposable,emailIsCorporate, andemailIsCanonicaltoUseruserAccessedAttoMembershipandPolicyMembershipPrivacytypetoBackupPolicyacceptheader on all requests, including chunked uploadssetImpersonateUserIdsetter on location methods (downloads, previews, views, avatars)