fix(console): correct usage chart labels from functions/sites to deployments#2986
Open
singhvishalkr wants to merge 2 commits intoappwrite:mainfrom
Open
fix(console): correct usage chart labels from functions/sites to deployments#2986singhvishalkr wants to merge 2 commits intoappwrite:mainfrom
singhvishalkr wants to merge 2 commits intoappwrite:mainfrom
Conversation
Contributor
Greptile SummaryThis PR fixes a label mismatch in the usage charts for the Functions and Sites pages: the chart metadata previously displayed "Total functions" / "Total sites" even though both pages source their data from Confidence Score: 5/5Safe to merge — two-line label-only changes with no logic impact. The changes are purely cosmetic string corrections that align chart labels with the actual data source already in use. No logic, data flow, or security concerns introduced. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "fix(sites): correct usage chart label fr..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2224
The usage chart on both the Functions and Sites aggregate usage pages displays incorrect labels. The data source is
deploymentsTotal/deployments, but the chart metadata says "Total functions" / "Total sites" respectively.Changes
legendfrom "Functions" to "Deployments" andtitlefrom "Total functions" to "Total deployments"legendfrom "Sites" to "Deployments" andtitlefrom "Total sites" to "Total deployments"Both pages load deployment metrics from the API (
data.deploymentsTotal,data.deployments), so the labels should reflect that.Files changed
src/routes/(console)/project-[region]-[project]/functions/usage/[[period]]/+page.sveltesrc/routes/(console)/project-[region]-[project]/sites/usage/[[period]]/+page.svelteTest plan