Skip to content

chore: use netty.version property instead of hardcoded version in mysqlPlugin#41999

Open
khushalmajoka wants to merge 1 commit into
appsmithorg:releasefrom
khushalmajoka:release
Open

chore: use netty.version property instead of hardcoded version in mysqlPlugin#41999
khushalmajoka wants to merge 1 commit into
appsmithorg:releasefrom
khushalmajoka:release

Conversation

@khushalmajoka

@khushalmajoka khushalmajoka commented Jul 15, 2026

Copy link
Copy Markdown

Fixes #41901

Problem

The mysqlPlugin module hardcoded an outdated Netty version (4.1.75.Final) for the netty-resolver-dns-native-macos dependency, bypassing the centrally managed ${netty.version} property in the parent pom.xml. This outdated version is flagged with known CVEs.

Fix

Replaced the two hardcoded 4.1.75.Final version strings with ${netty.version}, which is already pinned to 4.1.135.Final in the parent pom.xml specifically to address these CVEs. This keeps the dependency in sync with the rest of the project going forward.

Testing

Ran mvn -pl appsmith-plugins/mysqlPlugin -am install -DskipTests — build succeeds with no compilation or dependency resolution issues.

Summary by CodeRabbit

  • Chores
    • Improved consistency for macOS-specific networking components by aligning them with the application’s centrally managed versioning.
    • This helps maintain reliable builds and reduces the risk of compatibility issues across supported macOS environments.

@khushalmajoka
khushalmajoka requested a review from a team as a code owner July 15, 2026 17:33
@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: fd9eae83-787e-4e06-a323-26a3b132cb75

📥 Commits

Reviewing files that changed from the base of the PR and between d2ec04c and 98c6e54.

📒 Files selected for processing (1)
  • app/server/appsmith-plugins/mysqlPlugin/pom.xml

Walkthrough

The MySQL plugin’s two macOS native Netty DNS dependencies now use the ${netty.version} Maven property instead of the fixed 4.1.75.Final version.

Changes

Netty dependency alignment

Layer / File(s) Summary
Align macOS Netty dependency versions
app/server/appsmith-plugins/mysqlPlugin/pom.xml
Both osx-x86_64 and osx-aarch_64 Netty DNS native dependencies now reference ${netty.version}.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested labels: ok-to-test

Poem

Two native paths now share one tune,
Netty versions align beneath the moon.
x86 and ARM agree,
A tidier POM for all to see.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The change fixes mysqlPlugin's hardcoded Netty version, but the linked issue also calls out awsLambdaPlugin HTTP codec CVEs. Also update the awsLambdaPlugin Netty HTTP codec dependency, or narrow the issue scope if mysqlPlugin was the only intended fix.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the Netty version cleanup in mysqlPlugin.
Description check ✅ Passed The description covers problem, fix, testing, and the issue reference, so it is mostly complete.
Out of Scope Changes check ✅ Passed The only code change is the Netty version substitution in mysqlPlugin, which matches the stated objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@subrata71

Copy link
Copy Markdown
Collaborator

/build-deploy-preview skip-tests=true

@github-actions

Copy link
Copy Markdown

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/29437658006.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 41999.
recreate: .
base-image-tag: .

@github-actions

Copy link
Copy Markdown

Deploy-Preview-URL: https://ce-41999.dp.appsmith.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Security Vulnerabilities: Netty CVEs in appsmith-ce:v2.1

2 participants