chore: use netty.version property instead of hardcoded version in mysqlPlugin#41999
chore: use netty.version property instead of hardcoded version in mysqlPlugin#41999khushalmajoka wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe MySQL plugin’s two macOS native Netty DNS dependencies now use the ChangesNetty dependency alignment
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested labels: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/build-deploy-preview skip-tests=true |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/29437658006. |
|
Deploy-Preview-URL: https://ce-41999.dp.appsmith.com |
Fixes #41901
Problem
The
mysqlPluginmodule hardcoded an outdated Netty version (4.1.75.Final) for thenetty-resolver-dns-native-macosdependency, bypassing the centrally managed${netty.version}property in the parent pom.xml. This outdated version is flagged with known CVEs.Fix
Replaced the two hardcoded
4.1.75.Finalversion strings with${netty.version}, which is already pinned to4.1.135.Finalin the parent pom.xml specifically to address these CVEs. This keeps the dependency in sync with the rest of the project going forward.Testing
Ran
mvn -pl appsmith-plugins/mysqlPlugin -am install -DskipTests— build succeeds with no compilation or dependency resolution issues.Summary by CodeRabbit