Potential fix for code scanning alert no. 1: Uncontrolled command line#9
Draft
appsecninja32 wants to merge 3 commits into
Draft
Potential fix for code scanning alert no. 1: Uncontrolled command line#9appsecninja32 wants to merge 3 commits into
appsecninja32 wants to merge 3 commits into
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…ed in path expression' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ed in path expression' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
| if not re.fullmatch(r"[A-Za-z0-9._\-]+", ruleset): | ||
| return {"results": [], "error": "Invalid local ruleset name"} | ||
| try: | ||
| candidate = (rules_dir / ruleset).resolve(strict=True) |
| raise FileNotFoundError(f"Target path not found: {target}") | ||
| base_dir = Path(__file__).resolve().parent | ||
| try: | ||
| target = (base_dir / target_path).resolve(strict=True) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/appsecninja32/CosmoGrepperAI/security/code-scanning/1
Best fix: enforce strict validation on both user-influenced arguments before subprocess execution, and remove shell execution mode.
In
scan_engine.pyinsiderun_semgrep_json:pathusingPath(path).resolve(strict=True)so only existing local paths are allowed.ruleset:p/...), only allow safe characters via regex allowlist.<BASE_DIR>/rulesand ensure it stays inside that directory.cmdwith normalized safe values.shell=Falseon all platforms.This preserves behavior (scan requested path/ruleset) while removing command-injection vector and addressing all variants (
pathandrulesetfrom both endpoints).Suggested fixes powered by Copilot Autofix. Review carefully before merging.