Skip to content

resolving a specific performance issue (hang) during startup. #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pfichtner wants to merge 3 commits into
base: main
Choose a base branch
from
+2 −1
Open

resolving a specific performance issue (hang) during startup. #259

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
011cdda
B!! add 5s timeout to requests.get in log_commons.py
pfichtner May 21, 2026
8cb85d1
B!! remove top-level side-effect to prevent import-time hang
pfichtner May 21, 2026
6fb25e9
Revert "B!! remove top-level side-effect to prevent import-time hang"
pfichtner May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion approvaltests/internals/logs/log_commons.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ def download_script_from_common_repo_if_needed(
return False

response = requests.get(
f"https://raw.githubusercontent.com/approvals/ApprovalTests.CommonScripts/refs/heads/main/{script_name_with_suffix}"
f"https://raw.githubusercontent.com/approvals/ApprovalTests.CommonScripts/refs/heads/main/{script_name_with_suffix}",
timeout=5
)
if response.ok:
script_path.write_text(response.text)
Expand Down