vminitd (client): Turn off idle timeout#680
Merged
dcantah merged 1 commit intoapple:mainfrom Apr 13, 2026
Merged
Conversation
There's no reason to have an idle timeout per connection as users may use this library in many different ways. The grpc lib defaults to a 30 min idle timeout which could be trivially reached if instead of waiting on the init process, you were waiting on a bunch of execs. NIO under the hood asserts on ebadfs (which is good, but bad for this scenario..), so lets turn off the timeout altogether.
jglogan
reviewed
Apr 13, 2026
Contributor
jglogan
left a comment
jglogan
left a comment
There was a problem hiding this comment.
We should also configure the client.
| .withConnectedSocket(connection.fileDescriptor).wait() | ||
| let transport = HTTP2ClientTransport.WrappedChannel.wrapping( | ||
| channel: channel, | ||
| config: .defaults { $0.connection.maxIdleTime = nil } |
Contributor
There was a problem hiding this comment.
Client side defaults to a 30 minute timeout as well:
Member
Author
There was a problem hiding this comment.
That's what this change is
Contributor
There was a problem hiding this comment.
For some reason I thought I was looking at the server code, my bad.
dcantah
changed the title
jglogan
approved these changes
Apr 13, 2026
| .withConnectedSocket(connection.fileDescriptor).wait() | ||
| let transport = HTTP2ClientTransport.WrappedChannel.wrapping( | ||
| channel: channel, | ||
| config: .defaults { $0.connection.maxIdleTime = nil } |
Contributor
There was a problem hiding this comment.
For some reason I thought I was looking at the server code, my bad.
This was referenced Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #678
There's no reason to have an idle timeout per connection as users may use this library in many different ways. The grpc lib defaults to a 30 min idle timeout which could be trivially reached if instead of waiting on the init process, you were waiting on a bunch of execs. NIO under the hood asserts on ebadfs (which is good, but bad for this scenario..), so lets turn off the timeout altogether.