Fix launchd domain mismatch between container system start/stop - #2050
Draft
JaewonHur wants to merge 1 commit into
Draft
Fix launchd domain mismatch between container system start/stop#2050JaewonHur wants to merge 1 commit into
container system start/stop#2050JaewonHur wants to merge 1 commit into
Conversation
getDomainString() picked gui/<uid> or user/<uid> based on the calling shell's launchd session type (Aqua vs Background), so registering the apiserver from a GUI Terminal and stopping it from tmux/ssh computed different domains, causing bootout to silently target a domain the service was never registered in. Always resolve to user/<uid> instead: it's the parent of the Aqua session domain for the same UID, so lookups from GUI shells still find it, and start/stop now agree regardless of which shell invokes them.
JaewonHur
marked this pull request as draft
July 31, 2026 18:30
Contributor
Author
|
Has some issue when |
Code Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
getDomainString() picked gui/ or user/ based on the calling shell's launchd session type (Aqua vs Background), so registering the apiserver from a GUI Terminal and stopping it from tmux/ssh computed different domains, causing bootout to silently target a domain the service was never registered in.
Always resolve to user/ instead: it's the parent of the Aqua session domain for the same UID, so lookups from GUI shells still find it, and start/stop now agree regardless of which shell invokes them.
Testing