fix(install): surface tar's real failure cause on extraction (ADFA-4544)#133
Merged
Merged
Conversation
The rootfs install extraction only logged "write failed: EPIPE (Broken pipe)" from the Java gzip -> tar pipe and reported a generic "Decompression failed", because it threw before reaching tarProcess.waitFor() — hiding tar's real exit code and stderr. EPIPE just means the tar child closed its stdin (it failed or was killed) mid-stream. - On a broken pipe, stop feeding and fall through to waitFor() to capture tar's real exit code (137/signal => killed by the Android 12+ phantom-process killer or OOM). - Retain the last 20 lines of tar output (stderr is merged) and include them in the error (an ENOSPC would show "No space left on device" here). - Log available disk space (StatFs) before extraction and on failure, plus bytes written. Diagnostic-only: the happy path is unchanged. Turns the opaque EPIPE into an actionable error (kill vs ENOSPC). Relates to ADFA-4496 (phantom-process handling in the sync path).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rootfs install extraction only logged "write failed: EPIPE (Broken pipe)" from the Java gzip -> tar pipe and reported a generic "Decompression failed", because it threw before reaching tarProcess.waitFor() — hiding tar's real exit code and stderr. EPIPE just means the tar child closed its stdin (it failed or was killed) mid-stream.
Diagnostic-only: the happy path is unchanged. Turns the opaque EPIPE into an actionable error (kill vs ENOSPC). Relates to ADFA-4496 (phantom-process handling in the sync path).