Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
==========================================
- Coverage 91.17% 91.08% -0.10%
==========================================
Files 12 12
Lines 1984 2031 +47
==========================================
+ Hits 1809 1850 +41
- Misses 175 181 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
cubic analysis
1 issue found across 8 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/utils.rs">
<violation number="1" location="src/utils.rs:72">
P1: According to linked Linear issue DEV-106, `--since`/`--until` should accept human relative dates like `"7 days ago"`, but this parser only accepts compact forms like `7d` and leaves human-form input unchanged.</violation>
</file>
Linked issue analysis
Linked issue: DEV-106: Allow human relative dates (e.g. "7 days ago") as values for --since and --until
| Status | Acceptance criteria | Notes |
|---|---|---|
| ✅ | Accept compact relative durations (e.g., 30m, 24h, 7d, 2w) for --since and --until | Added resolve_relative_datetime supporting m/h/d/w |
| ✅ | Apply relative duration support to request-logs command (--since/--until) | request_logs maps since/until through resolve_relative_datetime |
| ✅ | Apply relative duration support to metrics command (--since/--until) | metrics maps since/until through resolve_relative_datetime |
| ✅ | Apply relative duration support to consumers command (--requests-since) | consumers maps requests_since via resolve_relative_datetime |
| ✅ | Parsing/resolution implemented in the CLI (client-side), not the API | resolve_relative_datetime added in CLI utils and used before API calls |
| ✅ | Preserve ISO 8601 input unchanged when not a relative duration | Function returns original string when pattern not matched |
| ❌ | Accept natural-language phrases like "7 days ago" (spaces/words) | Only compact formats accepted; phrases not parsed |
| ✅ | Update CLI help/docs to mention relative duration support | Docs and arg help updated to show relative duration examples |
| ✅ | Add unit tests for relative duration parsing | Includes test_resolve_relative_datetime with checks |
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Allow relative durations (e.g. 30m, 24h, 7d, 2w) for
--since,--until, and--requests-sincein the CLI. Implements DEV-106.New Features
request-logs,metrics, andconsumers; inputs like<digits><m|h|d|w>resolve tonow - durationin UTC (RFC 3339). Parsing is done in the CLI; API behavior is unchanged.skills/apitally-cli/references/commands.md.Bug Fixes
consumers --requests-sinceand pass it correctly to the API.Written for commit 213f325. Summary will update on new commits.