fix: respect explicit zero custom_after_sleep in metamorph and reboot#971
Draft
vdusek wants to merge 1 commit into
Draft
fix: respect explicit zero custom_after_sleep in metamorph and reboot#971vdusek wants to merge 1 commit into
vdusek wants to merge 1 commit into
Conversation
The falsy check treated an explicit timedelta(0) as unset and silently replaced it with the 5-minute default. Check for None instead so callers can opt out of the after-sleep entirely.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #971 +/- ##
==========================================
+ Coverage 89.91% 90.01% +0.09%
==========================================
Files 49 49
Lines 3085 3085
==========================================
+ Hits 2774 2777 +3
+ Misses 311 308 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Actor.metamorph()andActor.reboot()used a falsy check oncustom_after_sleep, so an explicittimedelta(0)was treated as unset and silently replaced with the 5-minute default (Configuration.metamorph_after_sleep).is None, so an explicit zero now skips the after-sleep entirely, while omitting the argument (or passingNone) still uses the default.timedelta(0)and that the underlying API call is still made.🤖 Generated with Claude Code