fix: accept arbitrary JSON userData in ApifyRequestList#966
Open
vdusek wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #966 +/- ##
==========================================
- Coverage 89.91% 89.88% -0.04%
==========================================
Files 49 49
Lines 3085 3085
==========================================
- Hits 2774 2773 -1
- Misses 311 312 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
_RequestDetails.user_datawas typeddict[str, str], but the platformrequestListSourcesinput allows arbitrary JSON values inuserData, so e.g.{"depth": 1}raised aValidationError. Retyped todict[str, JsonSerializable](the same alias crawlee'sRequest.from_urldeclares).Request.from_urlmutates a non-emptyuser_datadict passed to it (writes__crawleeback into it), and_process_remote_urlreused one dict for every URL extracted from arequestsFromUrlsource. Any such source with non-emptyuserDataand 2+ extracted URLs crashed with aTypeErroron the second request. Each call now gets its own copy of the dict.