Skip to content

refactor!: Rename wait_for_finish to wait in Actor.start#962

Open
vdusek wants to merge 1 commit into
masterfrom
refactor/unify-actor-start-wait-param
Open

refactor!: Rename wait_for_finish to wait in Actor.start#962
vdusek wants to merge 1 commit into
masterfrom
refactor/unify-actor-start-wait-param

Conversation

@vdusek

@vdusek vdusek commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Description

  • Rename the wait_for_finish: int | None argument of Actor.start() to wait: timedelta | None, unifying it with Actor.call() and Actor.call_task(), which already use wait: timedelta for the same concept.
  • The argument is keyword-only, so old call sites fail with a TypeError instead of silently misbehaving. Behavior is unchanged, the server-side cap of 300 seconds still applies.
  • Fix the wait docstrings of Actor.call() and Actor.call_task(), which still said "maximum number of seconds" for a timedelta argument.
  • Document the rename in the v4 upgrading guide.

Unify the argument with Actor.call and Actor.call_task, which use wait: timedelta
for the same concept. The value is now a timedelta instead of an int in seconds.
@vdusek vdusek added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Jun 11, 2026
@vdusek vdusek self-assigned this Jun 11, 2026
@vdusek vdusek marked this pull request as ready for review June 11, 2026 12:49
@vdusek vdusek requested a review from szaganek as a code owner June 11, 2026 12:49
@vdusek vdusek requested a review from Pijukatel June 11, 2026 12:49
@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.88%. Comparing base (a87e8d1) to head (a1e295b).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #962      +/-   ##
==========================================
- Coverage   90.00%   89.88%   -0.13%     
==========================================
  Files          49       49              
  Lines        3053     3085      +32     
==========================================
+ Hits         2748     2773      +25     
- Misses        305      312       +7     
Flag Coverage Δ
e2e 35.98% <ø> (+0.31%) ⬆️
integration 56.95% <ø> (+0.09%) ⬆️
unit 78.70% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants