refactor!: Rename wait_for_finish to wait in Actor.start#962
Open
vdusek wants to merge 1 commit into
Open
Conversation
Unify the argument with Actor.call and Actor.call_task, which use wait: timedelta for the same concept. The value is now a timedelta instead of an int in seconds.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #962 +/- ##
==========================================
- Coverage 90.00% 89.88% -0.13%
==========================================
Files 49 49
Lines 3053 3085 +32
==========================================
+ Hits 2748 2773 +25
- Misses 305 312 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
wait_for_finish: int | Noneargument ofActor.start()towait: timedelta | None, unifying it withActor.call()andActor.call_task(), which already usewait: timedeltafor the same concept.TypeErrorinstead of silently misbehaving. Behavior is unchanged, the server-side cap of 300 seconds still applies.waitdocstrings ofActor.call()andActor.call_task(), which still said "maximum number of seconds" for atimedeltaargument.