fix: add idempotency_key, ignore_ssl_errors and do_not_retry to WebhookRepresentation#854
Draft
vdusek wants to merge 1 commit into
Draft
fix: add idempotency_key, ignore_ssl_errors and do_not_retry to WebhookRepresentation#854vdusek wants to merge 1 commit into
vdusek wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #854 +/- ##
==========================================
- Coverage 94.82% 94.60% -0.22%
==========================================
Files 48 48
Lines 5045 5063 +18
==========================================
+ Hits 4784 4790 +6
- Misses 261 273 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
start()/call()silently droppedidempotency_key,ignore_ssl_errorsanddo_not_retrybecauseWebhookRepresentationdeclared only the four templating fields andencode_webhooks_to_base64filters to declared fields. The platform accepts and honors all three for ad-hoc webhooks (verified in apify-core: the run-start handler feeds them into the same webhook-creation path as the create-webhook endpoint, including theidempotencyKeydedup).WebhookRepresentation, both webhook representation typed dicts, and theWebhookCreateprojection inencode_webhooks_to_base64.Webhookdataclass.