test: enable skywalking plugin in e2e apisix#32
Conversation
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Enables the Apache APISIX skywalking plugin for the repo’s E2E environment by explicitly declaring the plugin list in the APISIX configs used by CI and docker-compose.
Changes:
- Add explicit
pluginsarrays to the CI APISIX config soskywalkingis enabled without losing existing default plugin coverage. - Add the same explicit
pluginsarray to the docker-compose APISIX config for parity with CI.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/e2e/apisix_conf/config.yaml | Adds explicit plugin allow-list including skywalking for CI APISIX container startup. |
| test/e2e/apisix_conf/config-docker.yaml | Mirrors the explicit plugin allow-list (incl. skywalking) for local docker-compose E2E runs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| plugins: | ||
| - real-ip | ||
| - ai | ||
| - client-control | ||
| - proxy-control | ||
| - request-id | ||
| - zipkin | ||
| - skywalking | ||
| - ext-plugin-pre-req |
There was a problem hiding this comment.
Hardcoding the entire APISIX default plugin list makes future APISIX image upgrades a bit easier to trip over (it’s not obvious this list is intended to mirror the image defaults plus skywalking). Consider adding a short inline note about where this list was sourced from / that it should be reviewed when the APISIX Docker tag changes.
| plugins: | ||
| - real-ip | ||
| - ai | ||
| - client-control | ||
| - proxy-control | ||
| - request-id | ||
| - zipkin | ||
| - skywalking | ||
| - ext-plugin-pre-req |
There was a problem hiding this comment.
Nit: this file duplicates the full plugins list from the CI config, which is easy to forget about when updating the APISIX Docker tag. Consider adding a brief note here (or in both files) that the list is meant to track APISIX defaults plus skywalking, and should be reviewed on APISIX upgrades.
Summary
Verification