test: add ssl stream route ginkgo e2e#29
Conversation
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Adds new Ginkgo E2E specs to exercise the CLI lifecycle for SSL and stream-route resources against a real APISIX Admin API, including validation and not-found behaviors (and conditional skipping for stream mode disabled environments).
Changes:
- Add ordered Ginkgo E2E coverage for
sslcreate/list/export/get/update/delete flows (JSON + YAML). - Add ordered Ginkgo E2E coverage for
stream-routecreate/list/export/get/update/delete flows plus validation/not-found checks, with skip logic when stream mode is disabled. - Introduce small local helpers for teardown (via Admin API), temp file writing, PEM indentation, and stream-mode skip handling.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| _, stderr, err := runA6WithEnv(env, "stream-route", "get", streamRouteID) | ||
| skipIfStreamModeDisabled("", stderr, err) | ||
| g.Expect(err).To(HaveOccurred()) | ||
| g.Expect(strings.ToLower(stderr)).To(ContainSubstring("not found")) | ||
|
|
||
| _, stderr, err = runA6WithEnv(env, "stream-route", "update") | ||
| g.Expect(err).To(HaveOccurred()) | ||
| g.Expect(stderr).To(ContainSubstring("required flag")) | ||
|
|
||
| _, stderr, err = runA6WithEnv(env, "stream-route", "delete", streamRouteID, "--force") | ||
| skipIfStreamModeDisabled("", stderr, err) | ||
| g.Expect(err).To(HaveOccurred()) |
There was a problem hiding this comment.
In the stream-route not-found checks, the calls to skipIfStreamModeDisabled pass an empty stdout string. For consistency (and to avoid missing the disablement message if it ever appears on stdout), capture and pass the real stdout from runA6WithEnv in these cases too.
|
Addressed the Copilot review comment by passing the real stdout into skipIfStreamModeDisabled for the stream-route not-found checks as well. |
Summary
Notes
Verification