ZOOKEEPER-5069: Add AdminServer command to query watch registration details#2426
Open
hedong1123 wants to merge 2 commits into
Open
ZOOKEEPER-5069: Add AdminServer command to query watch registration details#2426hedong1123 wants to merge 2 commits into
hedong1123 wants to merge 2 commits into
Conversation
Author
|
The Jenkins failure is unrelated to this PR. It is a timeout in The watch_details-related tests passed, and the failing test passed when rerun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The existing
watches,watches_by_path, andwatch_summaryAdminServercommands do not provide per-Watch details correlated with current client
connection information. This makes Watch registration diagnostics difficult.
Changes
watch_detailsand the four-lettercommand alias
wchd.path,session_id, andclient_ipfilters, plus alimitparameter with a default of 100 and a maximum of 1000.
ZooKeeper ensemble.
connection establishment time, session timeout, and TLS state.
watch_kindas an ordered array of event coverage:["data"],["children"], or["data", "children"].path + session_id + watch_mode, so Data andChildren Watches for the same Standard Watch context are returned as one
entry.
returned_countandtruncated.IWatchManagerimplementations through a default interface method.