Skip to content

[ZEPPELIN-6520] Bind repository proxy password input to proxyPassword control#5291

Open
kimyenac wants to merge 1 commit into
apache:masterfrom
kimyenac:ZEPPELIN-6520
Open

[ZEPPELIN-6520] Bind repository proxy password input to proxyPassword control#5291
kimyenac wants to merge 1 commit into
apache:masterfrom
kimyenac:ZEPPELIN-6520

Conversation

@kimyenac

Copy link
Copy Markdown

What is this PR for?

In the interpreter "add repository" dialog, the proxy Password input was bound to the wrong reactive-form control (proxyLogin) — the same control the Login field already uses. As a result a proxy password could never be saved, and typing a proxy password overwrote the proxy login.

This PR binds the Password input to the proxyPassword control so that both proxy credentials are submitted independently.

create-repository-modal.component.html:

-      <input nz-input type="password" formControlName="proxyLogin" placeholder="proxy password" />
+      <input nz-input type="password" formControlName="proxyPassword" placeholder="proxy password" />

What type of PR is it?

Bug Fix

Todos

  • - Fix the form-control binding
  • - Add an e2e regression test

What is the ticket?

https://issues.apache.org/jira/browse/ZEPPELIN-6520

How should this be tested?

  • cd zeppelin-web-angular && npm run lint
  • A Playwright e2e test is added: e2e/tests/workspace/interpreter/create-repository-proxy-credentials.spec.ts. It fills the proxy login and proxy password in the add-repository modal and asserts the POST /api/interpreter/repository payload carries each value in its own field (proxyLogin / proxyPassword). The test fails on the current binding and passes with this fix.
  • Manually: add a repository with a proxy login and password in the interpreter UI and confirm both are sent.

Screenshots (if appropriate)

N/A — the form renders identically; the defect is only visible in the submitted payload.

Questions:

  • Does the license files need to update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

… control

The proxy Password input in the interpreter add-repository modal was bound to
the proxyLogin form control, so a proxy password could never be saved and
typing one overwrote the proxy login. Bind the Password input to the
proxyPassword control so both proxy credentials are submitted.

Add a Playwright e2e regression test that fills the proxy login and password
and asserts the add-repository request carries each value in its own field.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant