Skip to content

WICKET-7186: correctly delegate calls to wicket cleaner #1485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bitstorm merged 1 commit into from
Jun 11, 2026
+42 −0
Merged

WICKET-7186: correctly delegate calls to wicket cleaner #1485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions wicket-util/src/main/java/org/apache/wicket/util/file/FileCleaner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
package org.apache.wicket.util.file;

import java.io.File;
import java.nio.file.Path;

import org.apache.commons.io.FileCleaningTracker;
import org.apache.commons.io.FileDeleteStrategy;
Expand Down Expand Up @@ -52,6 +53,18 @@ public void track(final File file, final Object marker, FileDeleteStrategy delet
cleaner.track(file, marker, deleteStrategy);
}

@Override
public void track(Path file, Object marker)
{
cleaner.track(file, marker);
}

@Override
public void track(Path file, Object marker, FileDeleteStrategy deleteStrategy)
{
cleaner.track(file, marker, deleteStrategy);
}

@Override
public void destroy()
{
Expand Down
14 changes: 14 additions & 0 deletions wicket-util/src/main/java/org/apache/wicket/util/file/FileCleanerTrackerAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
package org.apache.wicket.util.file;


import java.nio.file.Path;

import org.apache.commons.io.FileCleaningTracker;
import org.apache.commons.io.FileDeleteStrategy;
import org.apache.wicket.util.lang.Args;
Expand Down Expand Up @@ -62,4 +64,16 @@ public void track(String path, Object marker, FileDeleteStrategy deleteStrategy)
{
fileCleaner.track(new File(path), marker, deleteStrategy);
}

@Override
public void track(Path file, Object marker)
{
fileCleaner.track(file, marker);
}

@Override
public void track(Path file, Object marker, FileDeleteStrategy deleteStrategy)
{
fileCleaner.track(file, marker, deleteStrategy);
}
}
15 changes: 15 additions & 0 deletions wicket-util/src/main/java/org/apache/wicket/util/file/IFileCleaner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
package org.apache.wicket.util.file;

import java.io.File;
import java.nio.file.Path;

import org.apache.commons.io.FileDeleteStrategy;

Expand Down Expand Up @@ -59,6 +60,20 @@ public interface IFileCleaner
*/
void track(File file, Object marker, FileDeleteStrategy deleteStrategy);

/**
* {@link Path} variant for file tracking.
*
* @see #track(File, Object)
*/
void track(Path file, Object marker);

/**
* {@link Path} variant for file tracking.
*
* @see #track(File, Object, FileDeleteStrategy)
*/
void track(Path file, Object marker, FileDeleteStrategy deleteStrategy);

/**
* Call this method to stop the cleaner and to free all allocated resources by it
*/
Expand Down