Add Presto cost profiling support and default parameters - #789
Open
JunWang222 wants to merge 23 commits into
Open
Add Presto cost profiling support and default parameters#789JunWang222 wants to merge 23 commits into
JunWang222 wants to merge 23 commits into
Conversation
Implement Presto (PrestoDB) as a Wayang platform module extending JdbcPlatformTemplate, same pattern as wayang-trino.
zkaoudi
requested changes
Aug 17, 2026
zkaoudi
left a comment
zkaoudi
left a comment
Contributor
There was a problem hiding this comment.
minor request, plus conflicts to be resolved
|
|
||
| // Instantiate Wayang and activate the Spark backend. | ||
| // Instantiate Wayang and activate the Java/Flink backends. | ||
| WayangContext wayangContext = makeContext(FLINK); |
Contributor
There was a problem hiding this comment.
I think here it has to be BOTH
…-profiling # Conflicts: # guides/cost-profiling.md # wayang-profiler/src/main/java/org/apache/wayang/profiler/log/GeneticOptimizerApp.java # wayang-tests-integration/src/test/java/org/apache/wayang/tests/FlinkIntegrationIT.java
zkaoudi
requested changes
Aug 21, 2026
| The Presto cost-profiling branch is named `feature/presto-cost-profiling`: | ||
|
|
||
| ```bash | ||
| git checkout feature/presto-cost-profiling |
Contributor
There was a problem hiding this comment.
Same here. No need to checkout
Contributor
Author
There was a problem hiding this comment.
modified, thanks！
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds Presto cost profiling support, including:
The default parameters are intended as starting values. For accurate optimization on a specific machine or deployment, users should follow the profiling guide and regenerate parameters locally.