Fix signature on flz_maxcopy to avoid cast error - #13532
Merged
Merged
Conversation
bneradt
approved these changes
Aug 11, 2026
Contributor
There was a problem hiding this comment.
Seems reasonable. Maybe submit a PR upstream?
https://github.com/ariya/FastLZ/
The lib/ directory contains third party code. When we update to a newer version, we will likely lose your change here unless this is changed in upstream.
Contributor
Author
|
Done: ariya/FastLZ#11 |
cmcfarlen
pushed a commit
that referenced
this pull request
Aug 12, 2026
flz_maxcopy takes void* arguments but calls fastlz_memcopy (taking uint8_t* arguments) without a cast. I don't see a reason for flz_maxcopy to not take uint8_t* arguments; for arch-specific speedups these get cast to the appropriately-sized pointer. Resolves build issues on ppc64le architecture. (cherry picked from commit ad0b638)
Contributor
|
Cherry-picked to the 10.2.x branch as a69c898 for the 10.2.0 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flz_maxcopy takes void* arguments but calls fastlz_memcopy (taking uint8_t* arguments) without a cast. I don't see a reason for flz_maxcopy to not take uint8_t* arguments; for arch-specific speedups these get cast to the appropriately-sized pointer. Resolves build issues on ppc64le architecture.